Skip to content

HIVE-2302: docs: Clarify metadataJSONSecretRef optional behavior for cluster adoption#2824

Open
huangmingxia wants to merge 1 commit intoopenshift:masterfrom
huangmingxia:docs/update-metadataJSONSecretRef-adoption-note
Open

HIVE-2302: docs: Clarify metadataJSONSecretRef optional behavior for cluster adoption#2824
huangmingxia wants to merge 1 commit intoopenshift:masterfrom
huangmingxia:docs/update-metadataJSONSecretRef-adoption-note

Conversation

@huangmingxia
Copy link
Contributor

@huangmingxia huangmingxia commented Jan 3, 2026

Add documentation for automatic metadata.json generation via retrofit code

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 3, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2026 •
edited by openshift-ci bot
Loading

@huangmingxia: This pull request references HIVE-2302 which is a valid jira issue.

Details

In response to this:

Add documentation for automatic metadata.json generation via retrofit code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huangmingxia
Once this PR has been reviewed and has the lgtm label, please assign dlom for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@huangmingxia huangmingxia marked this pull request as ready for review January 3, 2026 07:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2026
@openshift-ci openshift-ci bot requested review from 2uasimojo and jstuever January 3, 2026 07:17
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2026

@huangmingxia: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Jan 3, 2026

/unhold

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Jan 3, 2026

@2uasimojo Could you please help review this when you have time? Thanks!

@huangmingxia huangmingxia mentioned this pull request Jan 3, 2026
Open
2uasimojo
2uasimojo reviewed Jan 5, 2026
View reviewed changes
Copy link
Member

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this adds good information, BUT it implies a preference for using CD fields, whereas we want to encourage using an existing Secret or file, if those are available. LMK if you want help wordsmithing an alternative.

cc @jianping-shu

@jianping-shu
Copy link
Contributor

jianping-shu commented Jan 6, 2026

Here is the previous discussion thread
If wanted to let the retrofit code kick in firstly, need instruct the user to double check if metadata.json secret is available after the cluster adoption. If not, then provision it manually.
@2uasimojo Pls. help judge which is the best approach :)

@2uasimojo
Copy link
Member

2uasimojo commented Jan 7, 2026

Thanks @jianping-shu.

@huangmingxia please see the comment Jianping linked for an explanation of my reasoning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2uasimojo 2uasimojo 2uasimojo left review comments

@jstuever jstuever Awaiting requested review from jstuever

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huangmingxia @openshift-ci-robot @jianping-shu @2uasimojo